phpBB2Refugees.com Logo
Not affiliated with or endorsed by the phpBB Group

Register •  Login 

Continue the legacy...

Welcome to all phpBB2 Refugees!Wave Smilie

This site is intended to continue support for the legacy 2.x line of the phpBB2 bulletin board package. If you are a fan of phpBB2, please, by all means register, post, and help us out by offering your suggestions. We are primarily a community and support network. Our secondary goal is to provide a phpBB2 MOD Author and Styles area.

phpBB 2 maintenance repository on GitHub


 
Search this topic... | Search phpBB2 Discussion... | Search Box
Register or Login to Post    Index » phpBB2 Discussion  Previous TopicPrint TopicNext Topic
Author Message
ebourg
Board Member



Joined: 14 Mar 2018

Posts: 2



PostPosted: Wed Mar 14, 2018 8:46 am 
Post subject: phpBB 2 maintenance repository on GitHub

Hi all,

I started a repository on GitHub dedicated to the maintenance of phpBB 2. The repository is based on the version 2.0.23. It doesn't contain new features, but only bug fixes addressing the compatibility with recent versions of PHP (tested with PHP 7.0).

https://github.com/ebourg/phpbb2
Back to top
Vendethiel
Board Member



Joined: 26 Oct 2014

Posts: 62



PostPosted: Wed Mar 14, 2018 9:45 am 
Post subject: Re: phpBB 2 maintenance repository on GitHub

Nice project! Especially as OVH is starting to remove old php versions from their servers.

There's a way to unbust your mysqli layer without removing the query arrays (commit).
It doesn't matter in the slightest for basic phpbb cases, the object will just be casted to a boolean, but if you have advanced usages, it will start to break down.

I used a SplObjectStorage to fix it in Icy Phoenix.

_________________
Developer on EzArena, the ADR premod.
Developer on Icy Phoenix, the phpBB hybrid cms.
Developer on IntegraMOD.
Back to top
ebourg
Board Member



Joined: 14 Mar 2018

Posts: 2



PostPosted: Wed Mar 14, 2018 11:09 am 
Post subject: Re: phpBB 2 maintenance repository on GitHub

Thank you for the feedback. I didn't want to use the cast to boolean because it didn't look safe. As I understand as soon as a page opens two resultsets simultaneously it's likely to break. But maybe this issue is moot anyway because the only method reading the saved row/rowset is sql_fetchfield(), and if I'm not mistaken it's never used. That's why I simply removed the fields. I'll keep in mind the SplObjectStorage trick if ever the optimization must be preserved for some mods.

Are there other fixes in Icy Phoenix that would be worth backporting to a vanilla phpBB 2?
Back to top
Vendethiel
Board Member



Joined: 26 Oct 2014

Posts: 62



PostPosted: Wed Mar 14, 2018 5:01 pm 
Post subject: Re: phpBB 2 maintenance repository on GitHub

Quote:
Thank you for the feedback. I didn't want to use the cast to boolean because it didn't look safe. As I understand as soon as a page opens two resultsets simultaneously it's likely to break. But maybe this issue is moot anyway because the only method reading the saved row/rowset is sql_fetchfield(), and if I'm not mistaken it's never used. That's why I simply removed the fields. I'll keep in mind the SplObjectStorage trick if ever the optimization must be preserved for some mods.
You are right. However most phpBB2 boards are modded with cache and/or a "phpbbmyadmin"-style mod, and those tend to require that.

Quote:
Are there other fixes in Icy Phoenix that would be worth backporting to a vanilla phpBB 2?

Icy Phoenix is a hybrid phpBB2/phpBB3 codebase, taking things apart is Too Hardô.
I'm having troubles remembering what would effect phpBB2 itself, considering I have applied different fixes to my premod(ezarena), to IntegraMOD, and to Icy Phoenix over the years.

Also, since your repo is a fork, Github's codesearch is disabled...
In no specific order, I have those: (sorry if they don't actually matter in vanilla phpBB2)

_________________
Developer on EzArena, the ADR premod.
Developer on Icy Phoenix, the phpBB hybrid cms.
Developer on IntegraMOD.
Back to top
Display posts from previous:   
Register or Login to Post    Index » phpBB2 Discussion  Previous TopicPrint TopicNext Topic
Page 1 of 1 All times are GMT
 
Jump to:  

Index • About • FAQ • Rules • Privacy • Search •  Register •  Login 
Not affiliated with or endorsed by the phpBB Group
Powered by phpBB2 © phpBB Group
Generated in 0.0144 seconds using 15 queries. (SQL 0.0028 Parse 0.0005 Other 0.0111)
phpBB Customizations by the phpBBDoctor.com
Template Design by DeLFlo and MomentsOfLight.com Moments of Light Logo